D 2020-05-11T16:57:42.678
J comment <div>Dear\sRoy,</div><div><br\s/></div><div>thank\syou\sfor\sgreat\sKitCreator.\sThis\sis\sanother\sticket\sin\sthe\sseries\sof\sthis\sWiki\spage:</div><div>[https://wiki.tcl-lang.org/page/Embedding+TCL+program+in+DLL?V=28].</div><div><br\s/></div><div>In\sfolder:<br\s/></div><div>kitCreator/kitsh/buildsrc/kitsh0.0</div><div><br\s/></div><div>File\skitInit.c,\sLine\s392:</div><div><br\s/></div><div>&lt;verbatim&gt;</div><div>Tcl_SetVar(interp,\s"tclkit_system_encoding",\sTcl_DStringValue(&amp;encodingName),\s0);<br\s/></div><div>&lt;/verbatim&gt;<br\s/></div><div><br\s/></div><div>For\sme,\sthe\slast\sparameter\sshould\sbe\schanged\sfrom\s"0"\sto\s"TCL_GLOBAL_ONLY"\sto\smake\sthe\svariable\s"tclkit_system_encoding"\svisible\sfor\sboot.tcl.</div><div><br\s/></div><div>File\sboot.tcl,\sLine\s103:</div><div><br\s/></div><div>"encoding\ssystem"\sis\schecked\sfor\sresult\s"identity"\sas\sa\ssign,\sthat\sthe\ssystem\sencoding\sis\snot\sset.</div><div>Since\stcl\s8.6.0,\sthe\sdefault\sis\s"iso8859-1"\sand\snot\s"identity".</div><div><br\s/></div><div>Thus,\sI\spropose\sto\schange\sthe\scode\s(perhaps\sonly\sfor\stcl\s8.6.x)\sto:</div><div><br\s/></div><div>&lt;verbatim&gt;</div><div><br\s/></div><div>if\s{[info\sexists\s::tclkit_system_encoding]\s&amp;&amp;\s$::tclkit_system_encoding\s!=\s""\s&amp;&amp;\s[encoding\ssystem]\sne\s$::tclkit_system_encoding\s}\s{<br\s/>&nbsp;&nbsp;&nbsp;\scatch\s{<br\s/>&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\sencoding\ssystem\s$::tclkit_system_encoding<br\s/>&nbsp;&nbsp;&nbsp;\s}<br\s/>}</div><div><br\s/></div><div>&lt;/verbatim&gt;<br\s/></div><div><br\s/></div><div>This\sworks\sfor\sme\sto\schange\sthe\ssystem\sencoding\sto\s"cp1252"\susing\sa\sC-VFS\swithin\sa\sDLL.</div><div><br\s/></div><div>Another\schange\smay\sbe\sdone\sto\sthe\slines\sjust\safter\sthis\sblock:</div><div><br\s/></div><div>&lt;verbatim&gt;</div><div><br\s/></div><div>#\sIf\swe've\sstill\snot\sbeen\sable\sto\sset\sthe\sencoding,\srevert\sto\sTclkit\sdefaults<br\s/>if\s{[encoding\ssystem]\seq\s"identity"}\s{<br\s/>&nbsp;&nbsp;&nbsp;\scatch\s{<br\s/>&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\sswitch\s$::tcl_platform(platform)\s{<br\s/>&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\swindows&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\s{\sencoding\ssystem\scp1252\s}<br\s/>&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\smacintosh&nbsp;&nbsp;&nbsp;\s{\sencoding\ssystem\smacRoman\s}<br\s/>&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;\sdefault&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\s{\sencoding\ssystem\siso8859-1\s}<br\s/>&nbsp;&nbsp;&nbsp;\s&nbsp;&nbsp;&nbsp;\s}<br\s/>&nbsp;&nbsp;&nbsp;\s}<br\s/>}</div><div><br\s/></div><div>&lt;/verbatim&gt;</div><div><br\s/></div><div>I\ssuppose,\sthe\splatform\s"macintosh"\shas\schanged\sto\s"darwin".\sAs\sutf-8\sis\snow\sthe\sdefault\sfor\smac\sand\smany\sUnix\s(which\sis\san\salways\spresent\sinternal\sencoding),\sthis\sblock\smay\sperhaps\sbe\sremoved\sentirely.</div><div><br\s/></div><div>What\sdo\syou\sthink\s?</div><div><br\s/></div><div>Thank\syou\sfor\sall,</div><div>Harald<br\s/></div><div><br\s/></div><div><br\s/></div>
J foundin trunk
J login anonymous
J private_contact 0f366eb3e9e2fcab52b8ebacd197db9047186a5f
J severity Minor
J status Open
J title Kit:\sboot.tcl\suses\sencoding\s"identity"\sinstead\s"iso8859-1"\ssince\s8.6.0,\skitInit.c\sTCL_GLOBAL\sscope\smissing
J type Code\sDefect
K 570aa112299e92f023ec03ae226e4cbd797c55b8
U anonymous
Z c14c159a3968e134c1533b709a0a75be